ref(profiling): public methods for new API #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## armcknight/git-chain/profiling/new-continuous-apis/6-launch-profiling #4995 +/- ##
===========================================================================================================
+ Coverage 92.731% 92.748% +0.016%
===========================================================================================================
Files 673 674 +1
Lines 83158 83283 +125
Branches 30265 30367 +102
===========================================================================================================
+ Hits 77114 77244 +130
+ Misses 5948 5942 -6
- Partials 96 97 +1
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2fd0f0e | 1225.94 ms | 1247.47 ms | 21.53 ms |
| 9839a68 | 1228.24 ms | 1247.98 ms | 19.73 ms |
| cf7f7c2 | 1215.34 ms | 1239.89 ms | 24.55 ms |
| 284b1c6 | 1245.83 ms | 1264.37 ms | 18.53 ms |
| 0a0a2bf | 1213.19 ms | 1239.20 ms | 26.01 ms |
| 4f73298 | 1211.70 ms | 1234.02 ms | 22.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2fd0f0e | 22.30 KiB | 842.05 KiB | 819.75 KiB |
| 9839a68 | 22.30 KiB | 843.83 KiB | 821.52 KiB |
| cf7f7c2 | 22.30 KiB | 842.86 KiB | 820.56 KiB |
| 284b1c6 | 22.30 KiB | 843.83 KiB | 821.52 KiB |
| 0a0a2bf | 22.30 KiB | 843.82 KiB | 821.52 KiB |
| 4f73298 | 22.30 KiB | 843.23 KiB | 820.92 KiB |
Previous results on branch: armcknight/profiling/new-continuous-apis/7-combine-public-methods
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 541710b | 1219.14 ms | 1238.58 ms | 19.44 ms |
| ac230f1 | 1225.94 ms | 1253.06 ms | 27.13 ms |
| eca9f3d | 1221.33 ms | 1243.73 ms | 22.41 ms |
| 784d936 | 1219.02 ms | 1251.24 ms | 32.22 ms |
| 7606482 | 1229.80 ms | 1250.92 ms | 21.12 ms |
| 7edc56a | 1224.47 ms | 1250.91 ms | 26.45 ms |
| db54fb7 | 1223.35 ms | 1241.79 ms | 18.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 541710b | 22.30 KiB | 843.37 KiB | 821.07 KiB |
| ac230f1 | 22.30 KiB | 843.08 KiB | 820.78 KiB |
| eca9f3d | 22.30 KiB | 843.38 KiB | 821.07 KiB |
| 784d936 | 22.30 KiB | 841.48 KiB | 819.18 KiB |
| 7606482 | 22.30 KiB | 841.48 KiB | 819.17 KiB |
| 7edc56a | 22.30 KiB | 843.38 KiB | 821.07 KiB |
| db54fb7 | 22.30 KiB | 843.06 KiB | 820.75 KiB |
indragiek
reviewed
Mar 18, 2025
Sources/Swift/Integrations/Performance/SentryProfileOptions.swift
Outdated
Show resolved
Hide resolved
indragiek
reviewed
Mar 18, 2025
armcknight
force-pushed
the
armcknight/profiling/new-continuous-apis/7-combine-public-methods
branch
from
49166aa to
0d7a452
Compare
… around session definition
…w to deal with the deprecated usage in SentryEnabledFeaturesBuilder
armcknight
force-pushed
the
armcknight/git-chain/profiling/new-continuous-apis/6-launch-profiling
branch
from
7b6e093 to
a65fcde
Compare
armcknight
force-pushed
the
armcknight/profiling/new-continuous-apis/7-combine-public-methods
branch
from
5a35e76 to
d1dfcd0
Compare
…unch-profiling' into armcknight/profiling/new-continuous-apis/7-combine-public-methods
…unch-profiling' into armcknight/profiling/new-continuous-apis/7-combine-public-methods
…unch-profiling' into armcknight/profiling/new-continuous-apis/7-combine-public-methods
…unch-profiling' into armcknight/profiling/new-continuous-apis/7-combine-public-methods
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
armcknight
merged commit b8d0e7d
into
armcknight/git-chain/profiling/new-continuous-apis/6-launch-profiling
31 of 33 checks passed
armcknight
deleted the
armcknight/profiling/new-continuous-apis/7-combine-public-methods
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per some discussion about API terminology, we will not introduce new methods named
startProfileSession/stopProfileSession, instead continuing withstartProfiler/stopProfiler. also explain session a bit better in the SentryProfileOptions headerdocs#skip-changelog; for #4851